-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an optional input for checkout so it can be skipped, if needed #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be useful to skip the checkout if there is a prior step that does some setup. For example, a project might have a cython step that compiles some modules which should be packaged into the wheelhouse. This can be done in a prior step and then this action triggered with the checkout disabled.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@ansys-reviewer-bot review |
Okay, I will trigger a review of your PR. |
myoung301
changed the title
Add an optional input for checkout so it can be skipped, if needed
feat: add an optional input for checkout so it can be skipped, if needed
Jun 11, 2024
Fixed the syntax of the condition and verified it works with true, false, and without the parameter (defaults to true). |
LGTM! Merging. We will do a patch release with this change. |
Release on the way - v6 will have your change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkout remains the default, but can be skipped if set to false. This can be useful when there are prior steps to build elements that should be packed into the wheelhouse. For example, some projects have a step to build cython .pyd files and those .pyd files should go into the wheel file. The checkout step would purge the repo and clear the files from the previous build step. Now, projects that have this requirement can opt to skip the checkout.