Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use github context action_path for vulnerabilities action #483

Merged
merged 9 commits into from
May 7, 2024

Conversation

RobPasMue
Copy link
Member

As title says. Exploring the usage of GITHUB_ACTION_PATH...

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement General improvements to existing features label May 7, 2024
@RobPasMue
Copy link
Member Author

Testing on ansys/pyansys-geometry#1191

@RobPasMue RobPasMue marked this pull request as ready for review May 7, 2024 12:57
@RobPasMue RobPasMue requested a review from a team as a code owner May 7, 2024 12:57
@RobPasMue RobPasMue changed the title feat: use GITHUB_ACTION_PATH for vulnerabilities feat: use github context action_path for vulnerabilities action May 7, 2024
@RobPasMue
Copy link
Member Author

Can I get a review @ansys/pyansys-core?

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cannot wait to try action_path myself !

Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments:

check-vulnerabilities/check_vulnerabilities.py Outdated Show resolved Hide resolved
check-vulnerabilities/check_vulnerabilities.py Outdated Show resolved Hide resolved
@RobPasMue RobPasMue merged commit cd8e715 into main May 7, 2024
16 checks passed
@RobPasMue RobPasMue deleted the feat/vulnerabilities-decouple-script branch May 7, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants