-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check pyproject.toml file exists before opening it #480
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@@ -117,7 +117,7 @@ jobs: | |||
needs: commit-and-branch-style | |||
steps: | |||
- name: "Run documentation style checks" | |||
uses: ansys/actions/doc-style@main | |||
uses: ansys/actions/doc-style@fix/file-dne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we really merge this?????
Next time, please make sure you do not merge these kind of changes.... testing on workflow files is not recommended for this reason. We should test on some other independent repo/branch/whatever.... |
@RobPasMue main was failing, so anyone who was using doc-style@main whose repo did not have the pyproject.toml file was going to experience failures. This change was meant to be temporary and was a quick fix to prevent other repo workflows from failing (if they are referring to main and don't have a pyproject.toml file). Also, the ci_cd file for this repository was not going to pass with doc-style as main since it doesn't have the pyproject.toml file, so I had to change it to the temporary branch in order for it to pass |
I understand why you did it, don't worry. But next time let's do it a bit differently...
|
doc-style fails in main if pyproject.toml doesn't exist in the repository