Replace tox with taskfile as build tool #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
feat/taskfile
branch
8 times, most recently
from
676112a to
a47cb9b
Compare
ssbarnea
force-pushed
the
feat/taskfile
branch
2 times, most recently
from
5b9a47a to
0e3e725
Compare
ssbarnea
changed the title
priyamsahoo
approved these changes
Jun 2, 2022
ssbarnea
force-pushed
the
feat/taskfile
branch
2 times, most recently
from
8f36ee6 to
1ac02cc
Compare
This does not make `task` an official tool for our project, it adds a config file with most commands, so we can evaluate how well it works for us and if it can address some of the confusions we had with package.json and tox.ini, as both were quite limited.
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 12, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 12, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 17, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 18, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 18, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 18, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ssbarnea/ansible-language-server
that referenced
this pull request
Jun 18, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
added a commit
to ansible/ansible-language-server
that referenced
this pull request
Jun 18, 2022
As neither tox nor npm are really suitable as build build, especially for mixed (ts/py) projects, we start using a task. Related: ansible/vscode-ansible#511 Related: ansible/schemas#311
ssbarnea
pushed a commit
that referenced
this pull request
Mar 15, 2024
* add setting to toggle support for playbook adjacent collection * add code to provide support for playbook adjacent collections * add test fixtures * add tests * add hover tests * update test structure * fix linting * remove unused imports * remove unwanted logs and spaces * remove mocha reporter: tap option * update settings readme * add logs * debug * update logic to handle playbook adjacent collection insde docsLibrary rather than inside ansibleConfig * update tests * add utility file for supporting playbook adjacent collections * use docs library utility file for giving services for playbook adjacent collections * add logic to check the presence of module code inside PAC * update tests with negative cases for PAC * remove unused imports * remove commented lines * remove console logs * change setting name change setting name from supportPlaybookAdjacentCollections to usePlaybookAdjacentCollections * remove the setting for supporting playbook adjacent collections and provide support for it by default --------- Co-authored-by: Ganesh Nalawade <[email protected]>
ssbarnea
pushed a commit
that referenced
this pull request
Mar 15, 2024
## v1.2.0 ### Minor Changes - Add support for playbook adjacent collections (#511) @priyamsahoo - Use antsibull-docs-ts to render semantic markup (#563) @felixfontein ### Bugfixes - Fix isPlaybook method (#590) @priyamsahoo - Fix vars completion in task files (#589) @priyamsahoo - Return URI instead of filepath (#560) @ajinkyau Co-authored-by: Ansible DevTools <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As both
toxandnpmare quite limiting, we switch to use of taskfile (task) as build tool.