feat: add setting options for execution environment #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
requested review from
joshuawilson,
JPinkney,
ssbarnea,
tomaciazek,
webknjaz and
a team
as code owners
tomaciazek
suggested changes
Sep 27, 2021
|
@tomaciazek Good catch. Last-minute unintended edit before commit messed up the order. Have fixed your review comment now. Thank you! |
matburt
approved these changes
Sep 28, 2021
tomaciazek
reviewed
Sep 28, 2021
tomaciazek
approved these changes
Sep 29, 2021
* Add support for execution environment
* Add setting in package.json file to configure execution
environment related setting.
Example client `settings.json` for EE options (default)
```
{
"ansible.executionEnvironment.enabled": false,
"ansible.executionEnvironment.image": "quay.io/ansible/ansible-navigator-demo-ee:0.6.0",
"ansible.executionEnvironment.containerEngine": "auto",
"ansible.executionEnvironment.pullPolicy: "missing"
}
```
Related to ansible-langauge-server PR ansible/ansible-language-server#42
ganeshrn
force-pushed
the
executionEnvironment
branch
from
1a32570
to
d4cdbfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
environment related setting.
Example client
settings.jsonfor EE options (default)Related to ansible-langauge-server PR ansible/ansible-language-server#42