Allow use of ${workspaceFolder} in more commands #1299
Conversation
garymm
force-pushed
the
garymm/ansible-lint
branch
from
d3f6793
to
a37ab80
Compare
garymm
force-pushed
the
garymm/ansible-lint
branch
from
a37ab80
to
145aa7e
Compare
garymm
force-pushed
the
garymm/ansible-lint
branch
from
145aa7e
to
f02467b
Compare
| name === "ansible-lint" | ||
| ? settings.validation.lint.path | ||
| : path.join(path.dirname(settings.ansible.path), name); | ||
| return replaceWorkspaceFolderInPath(pathFromSettings, context); |
There was a problem hiding this comment.
I am sure the vscode api has generic support for replacing all variables in the settings, please use that instead of trying to do it DIY.
There was a problem hiding this comment.
I have been unable to find it.
This suggests it doesn't exist: microsoft/vscode#46471
There was a problem hiding this comment.
However if you can find it I'd be happy to use it!
|
@garymm Thanks for pointing to this upstream issue, see my comment from microsoft/vscode#46471 (comment) -- if nobody steps in to ensure that is maintained, we might want to add this as package under our extension and reuse the code from there. I do not fancy adding it as an npm dependency considering that the code was not touched in 4 years. |
|
@ssbarnea If you want to do that instead feel free to close this PR and open an issue for that. I still think this PR is on net helpful but I don't maintain this code base so obviously up to you / other maintainers. |
|
@garymm looks like library https://github.com/DominicVonk/vscode-variables has a new release and we can use it. |
|
@audgirka that'd be great if you could do that. I'm personally unlikely to do that any time soon. |
No description provided.