Push disposals to context.subscriptions #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
approved these changes
Mar 4, 2024
TamiTakamiya
deleted the
TamiTakamiya/push-disposals-to-context-subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VS Code extension development, all disposable objects created by the extension should be pushed to
context.subscriptionsso that they can be properly cleaned up when your extension is unloaded (reference). Most of disposables created in theactivate()method of Ansible VS Code extension are already pushed to it, but there are few exceptions. This PR is for pushing those disposables, which have not been pushed to it.