This repository has been archived by the owner on Dec 2, 2022. It is now read-only.
Improve gather facts and subset support #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
apatard
commented
Jun 22, 2022
apatard
commented
- add tests for gather_facts and gather_subset
- fix schema for gather_subset
Since support for import_playbooks has been added, the output of check-jsonschema will only output the error due to the play not matching the import_playbook schema (which is a normal thing) but won't show the actual error, so use -v to see all errors. Signed-off-by: Arnaud Patard <[email protected]>
gather_subset is not a boolean but an array of string, so fix the definition and add various tests files for it. Signed-off-by: Arnaud Patard <[email protected]>
While working on gather_subsets, thought it would be a good idea to add tests for gather_facts too. Signed-off-by: Arnaud Patard <[email protected]>
|
I seen that you left an extra |
ssbarnea
approved these changes
Jun 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.