Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

meta: allow use of collections key #244

Merged
merged 1 commit into from
Apr 29, 2022
Merged

meta: allow use of collections key #244

merged 1 commit into from
Apr 29, 2022
+30 −0

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea requested a review from a team as a code owner April 29, 2022 15:40
@ssbarnea ssbarnea added the bug Something isn't working label Apr 29, 2022
@ssbarnea ssbarnea requested a review from ziegenberg April 29, 2022 15:45
@ssbarnea ssbarnea merged commit 4aab7e0 into ansible:main Apr 29, 2022
@ssbarnea ssbarnea deleted the fix/more branch April 29, 2022 15:55
ziegenberg
ziegenberg reviewed Apr 29, 2022
View reviewed changes
test/roles/foo/meta/main.yml
@@ -1,3 +1,5 @@
collections:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
collections:
collections:
- foo_bar.foo_bar

I would use a case with an underscore.

@ziegenberg
Copy link
Collaborator

Oh, too late. Well, 10 minutes for a requested review was a bit short... 🤷🏻‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ziegenberg ziegenberg ziegenberg left review comments

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner automatically assigned from ansible/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @ziegenberg