Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

meta: require either src, name or role for each dependency entry #241

Merged
merged 1 commit into from
Apr 21, 2022
Merged

meta: require either src, name or role for each dependency entry #241

merged 1 commit into from
Apr 21, 2022

Conversation

ssbarnea
Copy link
Member

No description provided.

@ssbarnea ssbarnea requested a review from a team as a code owner April 21, 2022 18:20
@ssbarnea ssbarnea added the bug Something isn't working label Apr 21, 2022
s-hertel
s-hertel reviewed Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing missing is that dependencies may also be a list of strings, which seems like it should be valid to me, but looks accurate otherwise.

dependencies:
  - role1
  - role2

@ssbarnea ssbarnea merged commit 61723f2 into ansible:main Apr 21, 2022
@ssbarnea ssbarnea deleted the fix/more branch April 21, 2022 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel left review comments

@bcoca bcoca bcoca approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssbarnea @bcoca @s-hertel