Add schema for ansible-navigator #119
Conversation
|
Why do they use dashes instead of underscores for the ansible-navigator configuration file? :( |
ziegenberg
force-pushed
the
add-ansible-navigator-model
branch
3 times, most recently
from
4dfeae2 to
740bb20
Compare
webknjaz
requested review from
a team,
relrod,
cidrblock and
priyamsahoo
and removed request for
a team
ziegenberg
force-pushed
the
add-ansible-navigator-model
branch
from
740bb20 to
e31d5fe
Compare
|
Ok, I think I got a first version that's ready to be discussed. Tests are green and use the example settings file from https://ansible-navigator.readthedocs.io/en/latest/settings/#the-ansible-navigator-settings-file |
|
That is awesome and we will discuss it for sure, it was already on my todo list so that cames as a really nice xmas present. |
src/ansibleschemas/navigator.py
Outdated
| @@ -0,0 +1,280 @@ | |||
| # Used to generate JSON Validations chema for ansible-navigator config files | |||
| # https://github.com/ansible-community/ansible-lint/blob/master/.ansible-lint | |||
There was a problem hiding this comment.
That's a copy&paste error. I'll fix it
There was a problem hiding this comment.
Lets wait for @cidrblock on this one, he knows navigator better than anyone else and may be able to spot some schema mistakes.
There was a problem hiding this comment.
Fixed it with 34818cc.
It's quite common and kebab-case is nicer in places where snake_case is not required for things to be compatible with Python identifiers. |
ziegenberg
force-pushed
the
add-ansible-navigator-model
branch
from
b547e35 to
550100a
Compare
Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
ziegenberg
force-pushed
the
add-ansible-navigator-model
branch
from
550100a to
34818cc
Compare
|
Rebased onto current |
ssbarnea
changed the title
|
@ziegenberg TY for this btw..... It made my day :) |
|
@cidrblock You are welcome :) |
This is work-in-progress, but if there's something completely wrong I welcome comments.
Closes: ansible/ansible-navigator#188
Related: ansible/vscode-ansible#328