Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update receptorctl requirements files #994

Merged
merged 15 commits into from
Apr 15, 2024

Conversation

oraNod
Copy link
Collaborator

@oraNod oraNod commented Apr 11, 2024

This PR updates requirements for receptorctl and uses pip-compile to generate a complete dependency tree. Additionally it removes requirements that appear to be out of date and no longer in use. I've updated the containerfile in the tests folder to use the new requirements file but I think that is also out of date. However removing files outside the receptorctl folder seems like it should happen in a separate PR.

This PR also modifies the noxfile to use the requirements files and adds a nox session to pip-compile requirements for receptorctl.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.41%. Comparing base (049d051) to head (a179ae4).

@@            Coverage Diff             @@
##            devel     #994      +/-   ##
==========================================
- Coverage   40.44%   40.41%   -0.04%     
==========================================
  Files          42       42              
  Lines        6617     6617              
==========================================
- Hits         2676     2674       -2     
  Misses       3729     3729              
- Partials      212      214       +2     

see 2 files with indirect coverage changes

@oraNod oraNod marked this pull request as draft April 11, 2024 18:59
@oraNod oraNod marked this pull request as ready for review April 15, 2024 15:36
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thom-at-redhat thom-at-redhat merged commit de6e13a into ansible:devel Apr 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants