Add load_from_pem_data test #986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #986 +/- ##
==========================================
+ Coverage 39.89% 40.12% +0.22%
==========================================
Files 42 42
Lines 6617 6617
==========================================
+ Hits 2640 2655 +15
+ Misses 3773 3754 -19
- Partials 204 208 +4 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func setupGoodRSAPrivateKeyPEMData() []byte { | ||
| return []byte(`-----BEGIN RSA PRIVATE KEY----- |
Check failure
Code scanning / SonarCloud
Cryptographic private keys should not be disclosed
thom-at-redhat
force-pushed
the
add_load_from_pemfile_test
branch
from
2a05ab7
to
8471fd7
Compare
pkg/certificates/ca_test.go
Outdated
| defer ctrl.Finish() | ||
|
|
||
| o := mock_certificates.NewMockOser(ctrl) | ||
| switch tt.args.filename { |
There was a problem hiding this comment.
This whole switch case can be swaped for a function pointer in the test case list, something like this: https://github.com/ansible/receptor/blob/devel/pkg/workceptor/workceptor_test.go#L140
pkg/certificates/ca_test.go
Outdated
|
|
||
| o := mock_certificates.NewMockOser(ctrl) | ||
| switch tt.args.filename { | ||
| case failedToDecodeTestFilename: |
There was a problem hiding this comment.
same as previous comment 😄
I think keeping the expected calls with the test case definition in the list is more readable
|
No description provided.