Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context leaks #975

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Fix context leaks #975

merged 6 commits into from
Mar 25, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 39.63%. Comparing base (e32df9f) to head (6a8d5d5).

@@            Coverage Diff             @@
##            devel     #975      +/-   ##
==========================================
+ Coverage   39.61%   39.63%   +0.02%     
==========================================
  Files          42       42              
  Lines        6614     6615       +1     
==========================================
+ Hits         2620     2622       +2     
+ Misses       3796     3794       -2     
- Partials      198      199       +1
Files Coverage Δ
pkg/netceptor/conn.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@thom-at-redhat thom-at-redhat marked this pull request as ready for review March 20, 2024 20:54
@AaronH88
Copy link
Contributor

I think the name of the PR can do without the word "possible" 😄

@thom-at-redhat thom-at-redhat changed the title Fix possible context leaks Fix context leaks Mar 21, 2024
@thom-at-redhat
Copy link
Contributor Author

I think the name of the PR can do without the word "possible" 😄

Done

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

AaronH88
AaronH88 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit dfde572 into ansible:devel Mar 25, 2024
15 of 16 checks passed
@thom-at-redhat thom-at-redhat deleted the fix_context_leaks1 branch March 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thom-at-redhat @AaronH88