Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade guide #963

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Add upgrade guide #963

merged 3 commits into from
Mar 11, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.66%. Comparing base (15c45db) to head (99e71cc).

@@            Coverage Diff             @@
##            devel     #963      +/-   ##
==========================================
+ Coverage   39.50%   39.66%   +0.15%     
==========================================
  Files          42       42              
  Lines        6606     6606              
==========================================
+ Hits         2610     2620      +10     
+ Misses       3797     3792       -5     
+ Partials      199      194       -5     

see 3 files with indirect coverage changes

@samccann
Copy link
Contributor

samccann commented Mar 7, 2024

Since there is no difference between upgrading and installing, you can probably just not have this guide. You already have a porting guide where y'all can put important changes from one release to another that users need to know about or do something about, so this upgrade guide is optional.

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit b78f853 into ansible:devel Mar 11, 2024
18 checks passed
@thom-at-redhat thom-at-redhat deleted the add_upgrade_guide branch March 18, 2024 10:51
@thom-at-redhat
Copy link
Contributor Author

@samccann thank you for your comments, we will consider removing the upgrade guide in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants