-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auto/default to true in RECEPTOR_KUBE_SUPPORT_RECONNECT #940
Update auto/default to true in RECEPTOR_KUBE_SUPPORT_RECONNECT #940
Conversation
7115cb0
to
6992c32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #940 +/- ##
==========================================
- Coverage 36.36% 36.34% -0.02%
==========================================
Files 42 42
Lines 7890 7891 +1
==========================================
- Hits 2869 2868 -1
Misses 4849 4849
- Partials 172 174 +2
|
6992c32
to
e488962
Compare
lets set to enabled by default instead of auto auto doesn't function correctly |
The switch case in this PR only sets the reconnect behaviour to All other cases are set to true. So "default" is true unless garbage is given. Is this the behaviour you are expecting? |
Quality Gate failedFailed conditions 33.8% Duplication on New Code (required ≤ 3%) |
@TheRealHaoLiu The comments needed clarification, thanks for the catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
need to validate support version range of OCP with supported version of Controller to make sure we are currently not supporting any OCP that do not have the log timestamp bug |
No description provided.