Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto/default to true in RECEPTOR_KUBE_SUPPORT_RECONNECT #940

Merged

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cae6862) 36.36% compared to head (1cdcf58) 36.34%.

@@            Coverage Diff             @@
##            devel     #940      +/-   ##
==========================================
- Coverage   36.36%   36.34%   -0.02%     
==========================================
  Files          42       42              
  Lines        7890     7891       +1     
==========================================
- Hits         2869     2868       -1     
  Misses       4849     4849              
- Partials      172      174       +2     
Files Coverage Δ
pkg/workceptor/kubernetes.go 2.59% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

@TheRealHaoLiu
Copy link
Member

lets set to enabled by default instead of auto

auto doesn't function correctly

@AaronH88
Copy link
Contributor

AaronH88 commented Feb 7, 2024

lets set to enabled by default instead of auto

auto doesn't function correctly

The switch case in this PR only sets the reconnect behaviour to false in two cases:
When the env var is set to disabled
When the env var is set to something other than the three cases (enabled, disabled,auto)

All other cases are set to true. So "default" is true unless garbage is given. Is this the behaviour you are expecting?

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

33.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@thom-at-redhat
Copy link
Contributor Author

@TheRealHaoLiu The comments needed clarification, thanks for the catch!

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thom-at-redhat thom-at-redhat merged commit 5135fb8 into ansible:devel Feb 8, 2024
14 of 15 checks passed
@thom-at-redhat thom-at-redhat deleted the change_Reconnect_default branch February 8, 2024 16:11
@TheRealHaoLiu
Copy link
Member

need to validate support version range of OCP with supported version of Controller to make sure we are currently not supporting any OCP that do not have the log timestamp bug

@AaronH88 AaronH88 changed the title For RECEPTOR_KUBE_SUPPORT_RECONNECT, Update auto/default to true Update auto/default to true in RECEPTOR_KUBE_SUPPORT_RECONNECT Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants