Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added certreq test #938

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pkg/certificates/ca_test.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94cf499) 36.17% compared to head (99b8b1f) 36.40%.

@@            Coverage Diff             @@
##            devel     #938      +/-   ##
==========================================
+ Coverage   36.17%   36.40%   +0.22%     
==========================================
  Files          42       42              
  Lines        7878     7878              
==========================================
+ Hits         2850     2868      +18     
+ Misses       4860     4838      -22     
- Partials      168      172       +4     

see 4 files with indirect coverage changes

@thom-at-redhat thom-at-redhat marked this pull request as ready for review February 1, 2024 22:23
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 9f05dd2 into ansible:devel Feb 2, 2024
18 checks passed
@thom-at-redhat thom-at-redhat deleted the add_certreq_test branch February 2, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants