Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Go 1.20 and 1.21 #914

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

AaronH88
Copy link
Contributor

@AaronH88 AaronH88 commented Jan 4, 2024

This PR adds support for Go 1.20 and 1.21,
Updates to the latest version of quic-go along with fixing the breaking changes as a result,
Also introduces a new mutex lock for the packet conns readDeadline field, which was not thread safe before.

This PR also addresses the following CVE's

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4ca9363) 33.30% compared to head (a81c19a) 33.44%.

@@            Coverage Diff             @@
##            devel     #914      +/-   ##
==========================================
+ Coverage   33.30%   33.44%   +0.14%     
==========================================
  Files          40       40              
  Lines        7399     7409      +10     
==========================================
+ Hits         2464     2478      +14     
+ Misses       4792     4788       -4     
  Partials      143      143              
Files Coverage Δ
pkg/netceptor/packetconn.go 90.10% <100.00%> (+0.57%) ⬆️
pkg/netceptor/conn.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@kapouer
Copy link
Contributor

kapouer commented Jan 4, 2024

Building receptor on debian/trixie (with or without your patch) gives the same two failing test_workunit.py tests.
Running those two tests independently, or skipping test_mesh.py, let the tests pass.
So it's probably something about a socket not being properly closed between two tests.

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AaronH88
Copy link
Contributor Author

AaronH88 commented Jan 5, 2024

Building receptor on debian/trixie (with or without your patch) gives the same two failing test_workunit.py tests. Running those two tests independently, or skipping test_mesh.py, let the tests pass. So it's probably something about a socket not being properly closed between two tests.

Thanks so much for the hint,
You were correct, the test right before the failing two was meant to clean up a work unit, but the test suite continued too fast, adding a sleep after the cleanup step fixed the problem.

Copy link
Collaborator

@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronH88 AaronH88 merged commit 3364035 into ansible:devel Jan 5, 2024
17 checks passed
@AaronH88 AaronH88 mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants