Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tagging task to the stage playbook #897

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Add tagging task to the stage playbook #897

merged 8 commits into from
Nov 22, 2023

Conversation

AaronH88
Copy link
Contributor

@AaronH88 AaronH88 commented Nov 20, 2023 •
edited
Loading

Annotated tags need to be created as part of the ci pipeline.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #897 (3e281ca) into devel (dad44ad) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #897      +/-   ##
==========================================
- Coverage   33.47%   33.31%   -0.17%     
==========================================
  Files          40       40              
  Lines        7399     7399              
==========================================
- Hits         2477     2465      -12     
- Misses       4783     4791       +8     
- Partials      139      143       +4

see 2 files with indirect coverage changes

@AaronH88 AaronH88 force-pushed the tagworkflow branch 6 times, most recently from 0033650 to f95d8ce Compare November 20, 2023 16:15
@AaronH88 AaronH88 force-pushed the tagworkflow branch 2 times, most recently from 645dd38 to 3bf0e6f Compare November 20, 2023 19:32
@AaronH88 AaronH88 added blocked and removed blocked labels Nov 20, 2023
@AaronH88
Copy link
Contributor Author

AaronH88 commented Nov 20, 2023 •
edited
Loading

Tested on my own fork here: https://github.com/AaronH88/receptor/actions/runs/6935456671/job/18865619828

This job will only be alive for a few weeks, but this PR can also be verified by doing the following:

git clone https://github.com/AaronH88/receptor.git
git tag
git show v1.4.3                       (OLD Style without annotated tags)
git show v1.4.6                       (Correctly annotated tag)

@AaronH88 AaronH88 force-pushed the tagworkflow branch 7 times, most recently from 9112ed7 to 1005bdd Compare November 21, 2023 12:50
@AaronH88 AaronH88 removed the blocked label Nov 21, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AaronH88 AaronH88 merged commit b83b4d7 into ansible:devel Nov 22, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronH88 @shanemcd