Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for Ping.go inside netceptor #810

Merged
merged 23 commits into from
Aug 28, 2023
Merged

Unit tests for Ping.go inside netceptor #810

merged 23 commits into from
Aug 28, 2023

Conversation

matoval
Copy link
Collaborator

@matoval matoval commented Jul 27, 2023 •
edited
Loading

Create interface for Ping & Packetconn and add unit tests to cover netceptor/ping.go

Increase ping.go coverage from 0% to 92.5

AaronH88
AaronH88 reviewed Aug 1, 2023
View reviewed changes
pkg/netceptor/ping.go Outdated Show resolved Hide resolved
AaronH88
AaronH88 reviewed Aug 1, 2023
View reviewed changes
pkg/netceptor/ping.go Outdated Show resolved Hide resolved
AaronH88
AaronH88 reviewed Aug 1, 2023
View reviewed changes
pkg/netceptor/ping.go Outdated Show resolved Hide resolved
@AaronH88
Copy link
Contributor

AaronH88 commented Aug 1, 2023

Overall looking great, a few small things to think about and make the future work easier.

@matoval matoval changed the title Unit tests for Ping.go inside netceptor - 2 Unit tests for Ping.go inside netceptor Aug 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matoval matoval marked this pull request as ready for review August 24, 2023 03:58
AaronH88
AaronH88 reviewed Aug 24, 2023
View reviewed changes
pkg/netceptor/ping.go Outdated Show resolved Hide resolved
AaronH88
AaronH88 reviewed Aug 24, 2023
View reviewed changes
pkg/netceptor/ping.go Outdated Show resolved Hide resolved
AaronH88
AaronH88 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! lgtm

@AaronH88 AaronH88 merged commit 54ad74b into ansible:devel Aug 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matoval @AaronH88