Refactored logging in the workceptor package and the receptor-cli pac… #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronH88
force-pushed
the
workceptor_logger
branch
4 times, most recently
from
4e10450
to
9e5c8e3
Compare
shanemcd
reviewed
Feb 27, 2023
| } | ||
|
|
||
| // Trace outputs detailed packet traversal. | ||
| func Trace(format string, v ...interface{}) { |
AaronH88
force-pushed
the
workceptor_logger
branch
6 times, most recently
from
955caa0
to
da751b3
Compare
shanemcd
reviewed
Mar 1, 2023
| @@ -19,7 +19,7 @@ require ( | |||
| github.com/songgao/water v0.0.0-20200317203138-2b4b6d7c09d8 | |||
| github.com/stretchr/testify v1.8.1 | |||
| github.com/vishvananda/netlink v1.1.0 | |||
| golang.org/x/net v0.0.0-20220630215102-69896b714898 | |||
| golang.org/x/net v0.5.0 | |||
There was a problem hiding this comment.
@simaishi @rooftopcellist Do changes to these files break anything on your end? Unsure how the downstream golang builds work these days.
There was a problem hiding this comment.
We will need to re-create vendor tarball, but please go ahead and merge when you're ready. When a commit requires new vendor file, a pre-merge job for rpm build will fail and we'll know an update is needed.
AaronH88
force-pushed
the
workceptor_logger
branch
6 times, most recently
from
b34b26f
to
1714b9f
Compare
…kage. Removed unneeded log functions in logger.go.
AaronH88
force-pushed
the
workceptor_logger
branch
from
1714b9f
to
1b733d9
Compare
shanemcd
approved these changes
Mar 7, 2023
rooftopcellist
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kage.
Building on PR #723 , this PR follows the same logging methodology and extends it to the workceptor package. Also removed unneeded logging functions from logger.go.
Based off of Shanes PR here: #718
and the blog here: https://gogoapps.io/blog/passing-loggers-in-go-golang-logging-best-practices/#global-state