ignore pre-release in version comparison #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCP does not use proper semvar, example: 1.24.8-gke.401 instead of using + for build metadata they use - this PR will ignore `-<prerelease tag>` when doing version comparison
tested greater version and lesser version and all works as expected @fosterseth can i get a review |
fosterseth
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #708
GCP does not use proper semvar, example:
AKS does the same thing
instead of using + for build metadata they use - which indicate pre-release
this PR will ignore
-<prerelease tag>when doing version comparisoncurrently we have no clue if this mess with other "variants" of Kubernetes