Improve ExternalBackend context handling #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghjm
force-pushed
the
external_backend_context
branch
4 times, most recently
from
fbee48a
to
2e5055f
Compare
|
The test flake is strong today |
ghjm
force-pushed
the
external_backend_context
branch
from
2e5055f
to
75e39f6
Compare
fosterseth
approved these changes
Mar 28, 2022
|
@shanemcd looks good to me if it works for you |
shanemcd
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ExternalBackend does not allow a library user to know when a connection has ended. This PR adds a context at the ExternalSession level, which an external caller can monitor to detect when the connection is finished.
While looking into this, I found that when an ExternalSession is closed, it calls the cancel function of the whole ExternalBackend, which implies there can only ever be one session per backend. However, the created context is not saved correctly, so the cancel function doesn't actually have any effect on anything. This PR creates a new context object at the ExternalSession level, which can track and be cancelled by a session, without cancelling its parent backend.