Clone TLS config before changing it #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghjm
force-pushed
the
tls_expected_name_fix
branch
from
fb2d7fc
to
5676021
Compare
ghjm
force-pushed
the
tls_expected_name_fix
branch
from
5676021
to
3aa8561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetConfigForClientreturns a newtls.Configcustomized for the client currently connecting. The function is a closure ontlscfgfrom the outer scope, so when we assign totlscfg.VerifyPeerCertificate, our change affects future connections that reuse this configuration. The immediate solution is to make a local clone insideGetConfigForClientso our change doesn't propagate to the outer scope.