Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix receptorctl status output #532

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

fosterseth
Copy link
Member

before

Known Node   Known Connections
bar          {
                "fish": 1,
                "foo": 1
}
fish         {
                "bar": 1
}
foo          {
                "bar": 1
}

after

Known Node   Known Connections
bar          fish: 1 foo: 1 
fish         bar: 1 
foo          bar: 1 

@AlanCoding
Copy link
Member

Won't this have an impact on AWX? I don't think we use the --json flag (we could), but I don't see how this is conditional on requesting JSON.

@fosterseth
Copy link
Member Author

fosterseth commented Feb 8, 2022

@AlanCoding

there are 2 parts to receptorctl, ReceptorSocket which is the class that handles all socket IO, and the click library which is just the human-friendly command library which uses ReceptorSocket.

AWX interacts with receptor via the ReceptorSocket only, not via the click library.

in receptor.py

from receptorctl.socket_interface import ReceptorControl

This fix just affects click library usage, so it shouldn't have any impact on awx.

@fosterseth fosterseth merged commit cc32887 into ansible:devel Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants