Forcing receptor into path on make test #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shanemcd, second attempt at modifying the Makefile to ensure receptor is in the path. In the last PR you mentioned putting PWD before ${PATH}. Based on that, I thought the easiest way to ensure receptor would be in the path would to have test target depend on the receptor target. This would preclude testing with a receptor binary from a "random" location but I didn't really have a good scenario for doing that other than testing a random binary against the current tests. But I think this could be accomplished by just doing a
cp ```which receptor``` .. Let me know what you think. Is there any reason you can think of that we wouldn't want to test with ./receptor?