Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container-builder to CentOS stream 9 #1019

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.34%. Comparing base (a889787) to head (0752a78).
Report is 91 commits behind head on devel.

@@            Coverage Diff             @@
##            devel    #1019      +/-   ##
==========================================
- Coverage   40.36%   40.34%   -0.02%     
==========================================
  Files          42       42              
  Lines        6637     6637              
==========================================
- Hits         2679     2678       -1     
- Misses       3744     3747       +3     
+ Partials      214      212       -2     
Flag Coverage Δ
go 40.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@thenets
Copy link
Member

thenets commented Apr 25, 2024

I got an "image not found error". Investigating it...

$ make container-image-builder
$(./receptor-tester.sh container-runtime) build \
        -t ansible/receptor:builder \
        -f ./environments/container-builder/Containerfile \
        ./../
[+] Building 1.4s (2/2) FINISHED                                                                                                                   docker:default
 => [internal] load build definition from Containerfile                                                                                                      0.1s
 => => transferring dockerfile: 1.37kB                                                                                                                       0.0s
 => ERROR [internal] load metadata for docker.io/library/centos:stream9                                                                                      1.2s
------
 > [internal] load metadata for docker.io/library/centos:stream9:
------
Containerfile:1
--------------------
   1 | >>> FROM centos:stream9
   2 |     
   3 |     # Python options = [3.9, 3.11, 3.12]
--------------------
ERROR: failed to solve: centos:stream9: failed to resolve source metadata for docker.io/library/centos:stream9: docker.io/library/centos:stream9: not found

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thom-at-redhat
Copy link
Contributor Author

I got an "image not found error". Investigating it...

$ make container-image-builder
$(./receptor-tester.sh container-runtime) build \
        -t ansible/receptor:builder \
        -f ./environments/container-builder/Containerfile \
        ./../
[+] Building 1.4s (2/2) FINISHED                                                                                                                   docker:default
 => [internal] load build definition from Containerfile                                                                                                      0.1s
 => => transferring dockerfile: 1.37kB                                                                                                                       0.0s
 => ERROR [internal] load metadata for docker.io/library/centos:stream9                                                                                      1.2s
------
 > [internal] load metadata for docker.io/library/centos:stream9:
------
Containerfile:1
--------------------
   1 | >>> FROM centos:stream9
   2 |     
   3 |     # Python options = [3.9, 3.11, 3.12]
--------------------
ERROR: failed to solve: centos:stream9: failed to resolve source metadata for docker.io/library/centos:stream9: docker.io/library/centos:stream9: not found

This resolved by adding quay as you recommended. Thanks for the catch!

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit e5b4594 into ansible:devel Apr 25, 2024
16 checks passed
@thom-at-redhat thom-at-redhat deleted the update_container_builder branch April 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants