-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate receptorctl workflows with matrices #1003
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #1003 +/- ##
==========================================
- Coverage 41.15% 41.14% -0.02%
==========================================
Files 42 42
Lines 6640 6640
==========================================
- Hits 2733 2732 -1
Misses 3692 3692
- Partials 215 216 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
e56309a
to
008d3f5
Compare
- 3.9 | ||
|
||
env: | ||
FORCE_COLOR: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should colorize the output, which makes the CI log nicer. But I recommend playing with the rest of vars from https://github.com/ansible/pylibssh/blob/57e2802/.github/workflows/ci-cd.yml#L68-L73 / https://github.com/cherrypy/cheroot/blob/3591a1c/.github/workflows/ci-cd.yml#L61-L67 to see if there's more improvements from other vars. I know that there's a separate one for pre-commit, for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of standardizing our approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this: https://nox.thea.codes/en/stable/config.html#nox.sessions.Session.run_install.
(because session.run()
seems to return early and give us a None
under --no-install
; ref: https://nox.thea.codes/en/stable/usage.html#re-using-virtualenvs)
Additionally, having https://github.com/marketplace/actions/alls-green integrated would help with setting up a unified gate for branch protection. But that should probably be separate. |
Reminds me I still need to integrate that in the ansible-documentation repo. |
153833a
to
71d73e5
Compare
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
86d611e
to
239f1e3
Compare
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
c89830c
to
eadbf74
Compare
Quality Gate passedIssues Measures |
This PR makes a number of changes:
receptorctl/.VERSION
file so there is no need to call the makefile to run the receptorctl tests and lint sessions. It's probably better to call nox directly than to do makefile > noxfile.