Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ add custom-sized VM to cloud demo #96

Closed
wants to merge 1 commit into from

Conversation

l3acon
Copy link
Collaborator

@l3acon l3acon commented Sep 11, 2023

No description provided.

@l3acon
Copy link
Collaborator Author

l3acon commented Sep 11, 2023

@jce-redhat this is what I had, it's pretty bare-bones so totally open to suggestions.

@willtome
Copy link
Collaborator

LGTM

@willtome willtome self-requested a review September 12, 2023 18:05
@jce-redhat
Copy link
Collaborator

it might be simpler to just edit the existing cloud/setup.yml and add a new survey question to the Cloud / AWS / Create VM job template. the blueprint already specifies the aws_instance_size variable for each blueprint, so the new survey question would just override it.

@jce-redhat
Copy link
Collaborator

jce-redhat commented Sep 12, 2023

i tested this addition to the survey for "Cloud / AWS / Create VM" and it works. using require: false is key so that if no value is provided for the instance type, it will default to whatever is in the VM blueprint.

        - question_name: AWS Instance Type (defaults to blueprint value)
          type: text
          variable: create_vm_aws_instance_size
          required: false

EDIT: corrected variable name

@l3acon
Copy link
Collaborator Author

l3acon commented Sep 12, 2023

That is obviously simpler and better, opened new PR #97

@l3acon l3acon closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants