Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify types for molecule.util:merge_types #4298

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

Qalthos
Copy link
Collaborator

@Qalthos Qalthos commented Oct 10, 2024

  • Type merge_dicts with a bound TypeVar so that it is clearer about what it accepts and that it returns the same thing it takes in.
  • write_file was missed in the Path update. This updates the method to accept Paths and simplifies the method by using Path internally.

NestedDict can probably take the place of any nonspecific dict[str, Any] we have, though it might also be overly specific.

src/molecule/util.py Outdated Show resolved Hide resolved
@Qalthos Qalthos changed the title Two updates to util Two type updates for utils.py Oct 14, 2024
@Qalthos Qalthos force-pushed the util-update branch 3 times, most recently from c95dcd8 to 4b15b66 Compare October 14, 2024 13:03
@Qalthos Qalthos enabled auto-merge (squash) October 14, 2024 13:08
@Qalthos Qalthos changed the title Two type updates for utils.py Clarify types for molecule.util:merge_types Oct 14, 2024
@Qalthos Qalthos merged commit 1620ba0 into ansible:main Oct 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants