Drop flake8 but keep using pydoclint #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
Jun 25, 2024
This was referenced Jun 25, 2024
cidrblock
added a commit
that referenced
this pull request
Jun 26, 2024
Since flake8 has been removed, VsCode no longer provided feedback during devleopment about new docstring errors. This PR add a new task called `pydoclint` that runs pydoclint in the background. Message from pydoclint are parsed with a regex and presented in the problems tab of VsCode by the task. VsCode does not have native support fdor running a task on save, so a new extension is added to support that. The flake8 extension is removed which was an oversight in #4235 Related #4236
cidrblock
added a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a new feature in pydoclint that adds new checks by default