Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplemented templating (init command) #3959

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Reimplemented templating (init command) #3959

merged 1 commit into from
Jul 10, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 8, 2023

  • Replaced use of cookiecutter with ansible templates
  • Removed 'init role' command due to already being covered by ansible-galaxy
  • Removed support for custom templating from drivers

@ssbarnea ssbarnea requested review from a team as code owners July 8, 2023 11:58
@ssbarnea ssbarnea force-pushed the major/init-role branch 3 times, most recently from 33f7f25 to 8fda1ec Compare July 8, 2023 15:11
@ssbarnea
Reimplemented templating (init command)
77936db 
- Replaced use of cookiecutter with ansible templates
- Removed 'init role' command  due to already being covered by ansible-galaxy
- Removed support for custom templating from drivers
@ssbarnea ssbarnea added the major label Jul 10, 2023
@ssbarnea ssbarnea merged commit 21dcd2b into main Jul 10, 2023
@ssbarnea ssbarnea deleted the major/init-role branch July 10, 2023 12:57
@chenrui333 chenrui333 mentioned this pull request Aug 14, 2023
Merged
cidrblock pushed a commit that referenced this pull request Aug 15, 2023
@chenrui333 @pre-commit-ci
fix: remove role from init help info (#4010)
626d784 
relates to #3959

relates to Homebrew/homebrew-core#139499

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@theko2fi
Copy link

Removed support for custom templating from drivers....but WHY? What led to this decision? I would like to read about it if you guys documented it somewhere. Thanks

@iay iay mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziegenberg ziegenberg Awaiting requested review from ziegenberg ziegenberg was automatically assigned from ansible-community/molecule

@zhan9san zhan9san Awaiting requested review from zhan9san zhan9san was automatically assigned from ansible-community/molecule

@audgirka audgirka Awaiting requested review from audgirka audgirka was automatically assigned from ansible-community/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @theko2fi