Pin another instance of yapf to <0.27 #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this when I put together ansible#1915 Signed-off-by: Sean Myers <[email protected]>
tehsmyers
force-pushed
the
i-missed-a-yapf
branch
from
bb5085e to
6935e7b
Compare
decentral1se
approved these changes
Apr 11, 2019
webknjaz
reviewed
Apr 11, 2019
webknjaz
approved these changes
Apr 11, 2019
Thanks to @webknjaz for the suggestion! Signed-off-by: Sean Myers <[email protected]>
tehsmyers
force-pushed
the
i-missed-a-yapf
branch
from
0dcefd4 to
2fa11e5
Compare
webknjaz
reviewed
Apr 14, 2019
| @@ -69,7 +69,7 @@ usedevelop = false | |||
| [testenv:format] | |||
| commands = | |||
| yapf -i -r molecule/ test/ | |||
| deps = yapf>=0.25.0,<0.27 | |||
| deps = yapf>=0.25.0,<0.27 # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915 | |||
There was a problem hiding this comment.
oh.. this one seems wrong because it's parsed as a single line. we should turn it into a list
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this when I put together #1915