-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver sanity checks (only Docker for now ...) #1882
Merged
decentral1se
merged 1 commit into
ansible:master
from
decentral1se:feature/better-driver-sanity-checks
Apr 9, 2019
Merged
Add driver sanity checks (only Docker for now ...) #1882
decentral1se
merged 1 commit into
ansible:master
from
decentral1se:feature/better-driver-sanity-checks
Apr 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentral1se
changed the title
WIP: Proof-Of-Concept for driver sanity checks
Proof-Of-Concept for driver sanity checks
Mar 28, 2019
This is ready for review btw ... removed the "WIP" for now |
Something for ansible#1666 (comment). Signed-off-by: Luke Murphy <[email protected]>
decentral1se
force-pushed
the
feature/better-driver-sanity-checks
branch
from
March 30, 2019 09:00
ee2adb7
to
2955fad
Compare
decentral1se
changed the title
Proof-Of-Concept for driver sanity checks
Add driver sanity checks (only Docker for now ...)
Mar 30, 2019
Logs for missing docker dependency:
Logs for not having docker daemon running:
|
themr0c
approved these changes
Apr 5, 2019
Right, I'm going to merge this one then and let's see where it takes us! Thanks for the review! |
decentral1se
added a commit
to decentral1se/molecule
that referenced
this pull request
Apr 10, 2019
Follows from ansible#1882. Signed-off-by: Luke Murphy <[email protected]>
webknjaz
pushed a commit
that referenced
this pull request
Apr 10, 2019
Follows from #1882. Signed-off-by: Luke Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on point in #1666 (comment).
Main goals of this change are: implement sanity checks that stop the sequence before anything happens if the driver is missing anything it needs to successfully run the sequence. This will help users get faster feedback when facing the litany of issues that come with using a driver (for the first time, especially ...).