Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --parallel` in Tox documentation instead of Detox. #1683

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Use --parallel` in Tox documentation instead of Detox. #1683

merged 1 commit into from
Jan 24, 2019

Conversation

decentral1se
Copy link
Contributor

Closes #1682.

PR Type

  • Docs Pull Request

@decentral1se
Copy link
Contributor Author

@ragingpastry, what do you think about this? I saw that you added the DeTox stuff originally.

@ragingpastry
Copy link
Contributor

Looks great to me. Is the failure in 377 unrelated?

@decentral1se
Copy link
Contributor Author

Thanks. CI failure is unrelated. There is something going in that specific job which is flaking ...

@gundalow gundalow added the test Improvement to quality assurance: CI/CD, testing, building label Jan 23, 2019
@decentral1se
Copy link
Contributor Author

Shouldn't this be docs tagged @gundalow?

@gundalow gundalow added docs and removed test Improvement to quality assurance: CI/CD, testing, building labels Jan 24, 2019
webknjaz
webknjaz reviewed Jan 24, 2019
View reviewed changes
doc/source/ci.rst
@@ -247,4 +241,4 @@ You also must include the MOLECULE_EPHEMERAL_DIRECTORY variable in the
.. _`Jenkins`: https://jenkins.io/doc/book/pipeline/jenkinsfile
.. _`Gitlab`: https://gitlab.com
.. _`Tox`: https://tox.readthedocs.io/en/latest
.. _`Detox`: https://pypi.python.org/pypi/detox
.. _parallel functionality: https://tox.readthedocs.io/en/latest/config.html#cmdoption-tox-p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use intersphinx for this?

webknjaz
webknjaz approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤

@webknjaz webknjaz merged commit 39849db into ansible:master Jan 24, 2019
@webknjaz
Copy link
Member

@lwm JFYI you shouldn't have a period at the end of the commit title.

Here's some practices I normally recommend:

@decentral1se decentral1se mentioned this pull request Jan 25, 2019
Closed
@decentral1se decentral1se deleted the detox-deprecated branch January 25, 2019 11:23
@decentral1se decentral1se mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@themr0c themr0c themr0c approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@decentral1se @ragingpastry @webknjaz @themr0c @gundalow