enable middleware to log traceback on timeout #2254
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.2
kdelee
force-pushed
the
enable_graceful_timeout_logging
branch
2 times, most recently
from
edd4302
to
d30ad7d
Compare
|
@jctanner does this commit checker only accept issues in AAH ? |
gunicorn sends a signal 6 when it is about to timeout a request This middleware handles that request and logs a traceback. this aids in debugging infrastructure issues that may be causing requests to timeout.
kdelee
force-pushed
the
enable_graceful_timeout_logging
branch
from
d30ad7d
to
1025cc3
Compare
jctanner
removed
backport-4.2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
gunicorn sends a signal 6 when it is about to timeout a request This middleware handles that request and logs a traceback.
this aids in debugging infrastructure issues that may be causing requests to timeout.
Issue: https://issues.redhat.com/browse/AAP-29982 (caused by https://issues.redhat.com/browse/AAP-27692 )
Reviewers must know:
To test manually, change gunicorn timeout to much lower value and add sleep in a view
See django-ansible-base notes https://github.com/ansible/django-ansible-base/blob/2af5f34dd4887eeba65f48e01e488745e90f8f04/docs/logging.md?plain=1#L56-L70
PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit