Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI workflow issue #424

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

bmclaughlin
Copy link
Collaborator

@bmclaughlin bmclaughlin commented Aug 8, 2024

What does this PR do?

Get the workflows running again. The input definitions were missing for ci_workflow in the local reusable github actions. This PR adds them.

How should this be tested?

Due to the fix being in the reusable local workflow files, the ci_standalone and ci_dab_jwt workflows still won't run on this PR. I'm opening an additional PR in a few minutes that should have the workflows running due to this PR.

Is there a relevant Issue open for this?

No

Other Relevant info, PRs, etc

All other PRs recently that the CI hasn't even started. :(

@bmclaughlin bmclaughlin changed the title Fix quoting issue Fix workflow issue Aug 8, 2024
@bmclaughlin bmclaughlin changed the title Fix workflow issue Fix CI workflow issue Aug 8, 2024
@bmclaughlin bmclaughlin force-pushed the fix-quotes-in-workflows branch from a45a623 to 688e602 Compare August 8, 2024 13:52
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson enabled auto-merge (squash) August 8, 2024 14:05
@djdanielsson djdanielsson disabled auto-merge August 8, 2024 14:06
@djdanielsson djdanielsson merged commit 660aa94 into ansible:devel Aug 8, 2024
9 checks passed
@bmclaughlin bmclaughlin deleted the fix-quotes-in-workflows branch August 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants