Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown tables #349

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix markdown tables #349

merged 2 commits into from
Jan 15, 2024

Conversation

Tompage1994
Copy link
Contributor

What does this PR do?

Fixes broken CI caused by updated markdownlint

How should this be tested?

CI

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

@Tompage1994 Tompage1994 mentioned this pull request Jan 15, 2024
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed one merge conflict that was obvious to take your new code.

@sean-m-sullivan sean-m-sullivan merged commit 1ff2d1e into ansible:devel Jan 15, 2024
7 of 12 checks passed
sean-m-sullivan added a commit that referenced this pull request Feb 27, 2024
* Update pre-commit (#326)

Co-authored-by: branic <[email protected]>

* Update pre-commit

* Fix ansible-lint running against .py files (#332)

* Fix ansible-lint running against .py files

* Fix a pylint issue

* Update description in the user role README (#333)

Updated the one line description in the role.

Co-authored-by: Sean Sullivan <[email protected]>

* Fix version comparison (#337)

fix #334

alternative implementarion for #335

* Update pre-commit (#338)

Co-authored-by: branic <[email protected]>

* user: Fix password type field in README (#342)

The `password` type was set to bool instead of str.

Signed-off-by: Dimitri Savineau <[email protected]>

* update repository roles (#343)

Co-authored-by: David Danielsson <[email protected]>

* Update pre-commit (#344)

Co-authored-by: branic <[email protected]>

* Fix wording to sync (#345)

* Update pre-commit

* Fix markdown tables (#349)

Co-authored-by: Sean Sullivan <[email protected]>

* Update pre-commit (#348)

Co-authored-by: branic <[email protected]>
Co-authored-by: Sean Sullivan <[email protected]>

* Update pre-commit

* collection_remote: set sync_dependencies default to PAH default (#346)

Co-authored-by: David Danielsson <[email protected]>

* Fix typo in ah_group_roles variable

* Add branch specifics to Contributing guide (#360)

* Fix documentation for validate_certs (#364)

* Fixed issue in all roles where AH_HOST was not being defaulted to if no variable set (#363)

* Fix documentation for group_roles role (#359)

* Update pre-commit (#361)

Co-authored-by: branic <[email protected]>

---------

Signed-off-by: Dimitri Savineau <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: branic <[email protected]>
Co-authored-by: Tom Page <[email protected]>
Co-authored-by: Richard J Osborne <[email protected]>
Co-authored-by: Bruno Rocha <[email protected]>
Co-authored-by: Dimitri Savineau <[email protected]>
Co-authored-by: David Danielsson <[email protected]>
Co-authored-by: dbk-rabel <[email protected]>
Co-authored-by: Bram Mertens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants