Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group role management and other improvements #299

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Add group role management and other improvements #299

merged 7 commits into from
Aug 21, 2023

Conversation

sean-m-sullivan
Copy link
Contributor

@sean-m-sullivan sean-m-sullivan commented Aug 20, 2023 •
edited
Loading

What does this PR do?

major_changes:

  • Added group_roles role and module to manage and attach roles to groups. Glbal role assignment will only work in Galaxy 4.6 or AAP 2.3 or later, while the targeted role assignment will work in Galaxy 4.7 or AAP 2.4 and above.

minor_changes:

  • Updated output in multiple modules to provide more information.
  • Updated server version lookup to remove the dev portion if working on a developmental version of Galaxy.
  • Updated ah_groups module to use new Pulp endpoint. The change should be seamless.
  • added more permissions to the ah_role modules. Consult your web UI to see what roles are available specific to your version.
  • added more roles to the dispatch role

How should this be tested?

Automated tests have been added.

Is there a relevant Issue open for this?

#179

Tompage1994
Tompage1994 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelogs/fragments/group_roles.yml Outdated Show resolved Hide resolved
@Tompage1994 Tompage1994 merged commit 569cd79 into ansible:devel Aug 21, 2023
@sean-m-sullivan sean-m-sullivan mentioned this pull request Nov 4, 2023
Closed
@laurent-indermuehle laurent-indermuehle mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tompage1994 Tompage1994 Tompage1994 approved these changes

@rochacbruno rochacbruno Awaiting requested review from rochacbruno

@djdanielsson djdanielsson Awaiting requested review from djdanielsson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sean-m-sullivan @Tompage1994