Fix version comparison (impl 2) #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ansible#334 alternative implementarion for ansible#335
Closed
rochacbruno
requested review from
sean-m-sullivan,
Tompage1994 and
djdanielsson
Tompage1994
reviewed
Nov 17, 2023
sean-m-sullivan
approved these changes
Nov 17, 2023
|
@Tompage1994 no because it is allowed to do |
sean-m-sullivan
added a commit
that referenced
this pull request
Feb 27, 2024
* Update pre-commit (#326) Co-authored-by: branic <[email protected]> * Update pre-commit * Fix ansible-lint running against .py files (#332) * Fix ansible-lint running against .py files * Fix a pylint issue * Update description in the user role README (#333) Updated the one line description in the role. Co-authored-by: Sean Sullivan <[email protected]> * Fix version comparison (#337) fix #334 alternative implementarion for #335 * Update pre-commit (#338) Co-authored-by: branic <[email protected]> * user: Fix password type field in README (#342) The `password` type was set to bool instead of str. Signed-off-by: Dimitri Savineau <[email protected]> * update repository roles (#343) Co-authored-by: David Danielsson <[email protected]> * Update pre-commit (#344) Co-authored-by: branic <[email protected]> * Fix wording to sync (#345) * Update pre-commit * Fix markdown tables (#349) Co-authored-by: Sean Sullivan <[email protected]> * Update pre-commit (#348) Co-authored-by: branic <[email protected]> Co-authored-by: Sean Sullivan <[email protected]> * Update pre-commit * collection_remote: set sync_dependencies default to PAH default (#346) Co-authored-by: David Danielsson <[email protected]> * Fix typo in ah_group_roles variable * Add branch specifics to Contributing guide (#360) * Fix documentation for validate_certs (#364) * Fixed issue in all roles where AH_HOST was not being defaulted to if no variable set (#363) * Fix documentation for group_roles role (#359) * Update pre-commit (#361) Co-authored-by: branic <[email protected]> --------- Signed-off-by: Dimitri Savineau <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: branic <[email protected]> Co-authored-by: Tom Page <[email protected]> Co-authored-by: Richard J Osborne <[email protected]> Co-authored-by: Bruno Rocha <[email protected]> Co-authored-by: Dimitri Savineau <[email protected]> Co-authored-by: David Danielsson <[email protected]> Co-authored-by: dbk-rabel <[email protected]> Co-authored-by: Bram Mertens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #334
alternative implementarion for #335