Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent role rename if metadata and database role names match #2626

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Prevent role rename if metadata and database role names match #2626

merged 2 commits into from
Mar 2, 2021

Conversation

awcrosby
Copy link
Contributor

  • Centralize the validation of meta/main.yml role_name
  • Skip validation if metadata role_name already matches database role name

Resolves: #2622
JIRA tracker issue: AAH-388

newswangerd
newswangerd approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@newswangerd newswangerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it looks reasonable.

@awcrosby awcrosby merged commit 738f21c into ansible:devel Mar 2, 2021
@awcrosby awcrosby deleted the fix/role_renaming branch March 2, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newswangerd newswangerd newswangerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php-versions role name was just changed again
2 participants
@awcrosby @newswangerd