Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event sources only in alignment with eda-server #196

Closed
wants to merge 4 commits into from

Conversation

fkuep
Copy link

@fkuep fkuep commented Feb 13, 2024

#195
#182 (comment)
Volunteers don´t understand, they are in the wrong place.

@fkuep fkuep mentioned this pull request Feb 13, 2024
3 tasks
Comment on lines +4 to +6
Eda-collection is intended to provide the initial resources for getting started with the [eda-server](https://github.com/ansible/eda-server). Other third-party integrations should be delegated to the collections developed by the ansible community.
Some of the existing plugins in this collection that do not fit as well in the scope of the collection are just keep them there for backward compatibility.
They will be eventually deprecated at some point.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fkuep, we really appreciate your contribution and effort towards clarification. The EDA team is currently drafting the official statement regarding these points.

cc @josephpisciotta

Copy link
Author

@fkuep fkuep Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was meant as conversation starter, thats why I was a little lazy and did not fix all mistakes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sc68cal Would that have helped You not to waste the effort?
@Alex-Izquierdo

  • Is there a list of welcomed integrations ?
  • Will You have public meetings where we would ask beforehand ?
  • Are You planning to look for new homes for the tb orphaned plugins?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkuep I appreciate your willingness to generate discussion on this issue.

I had a video call with the maintainers of this repository a month ago where I raised the issues you are also raising. The commitment from their side was to provide clarity around what is the correct way to move forward with community contributed event sources.

My point has been that discoverability is critical to the success of EDA. Everyone looking to use EDA is going to look at this repository first for their preferred event source (rabbit, mqtt, etc etc) and when they don't find it here they're probably going to just move on and implement something themselves and not use Ansible at all.

From the Red Hat side, my recollection is that they are concerned about certifying all the code that is in this repository and providing support for community contributed event sources.

I understand this concern, being a former employee of Mirantis (and also IBM), so my suggestion was that there be a clear distinction between the parts that Red Hat wishes to certify and support, versus the community contributed ones.

This is usually done with a contrib namespace or directory, that signifies that these are contributed by the open source community.

I suggested something like ansible.eda.contrib or an equivalent Ansible galaxy collection that could contain those community contributed event sources, and have very good links in this repo's documentation to point to that collection, so that people don't just throw their hands up and walk away from EDA.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other suggestion from the Red Hat side was that event sources should be contributed to the existing collections for that component. In the case of the RabbitMQ event source, it should be contributed to https://github.com/ansible-collections/community.rabbitmq

I am fine with this suggestion, provided that my event source is accepted in that repository and links in this repository are added so that people can find it.

Copy link
Author

@fkuep fkuep Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sc68cal ,

I suggested something like ansible.eda.contrib or an equivalent Ansible galaxy collection that could contain those community contributed event sources, and have very good links in this repo's documentation to point to that collection, so that people don't just throw their hands up and walk away from EDA.

You already have a mock-queue as suggested e.g here.

I beleive the default awx execution environment includes community.general .
@Alex-Izquierdo who builds the default decision environment Your collection is in ?
Could "ansible.eda.contrib" go inside there, provided test are good ?
Could a non-profit "ansible.eda.contrib" collection integrate with their tools and push to quay.io so that beginners can use this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you mean a community collection equivalent to community.general, let's say community.eda.
ansible.eda.contrib would mean a plugin inside this collection which would not solve the problem. The current image of ansible-rulebook in quay.io serves as decision environment and already includes ansible.eda collection. The addition of such a hypothetical collection could be discussed.

Copy link
Author

@fkuep fkuep Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-Izquierdo Do You say that You are building the image here and are willing to discuss inclusion of an community.eda collection?
You are not yet using ansible-builder, so probably it would be great to be in on the dev toolchain ride with You

@sc68cal is community.eda a good name ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

community.eda works for me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-Izquierdo I guess now we would like You to

  • go to Your Team for us and secure us some intent to cooperate.
  • Please bring us back some love of collaboration from them.
  • Hurry - it is cold.

README.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 25, 2024

@ssbarnea ssbarnea closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants