-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
journald: basic ruff formating #139
Conversation
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Will fix line length later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Thomas Sjögren <[email protected]>
All checks passed 👍 |
Hi! all the fixes LGTM but there are still a few things here (PRs will always pass because this is not tested), I just fetched/rebased #139 on top of #138 and this is part of the output:
There are still a few things to fix before it passes. I would vote first to have the lint check merged (but disabled like in #138) so it is possible to verify that the styling is actually consistent. Future tests can be easily verified and merged. |
Will fix during the weekend, and use |
Signed-off-by: Thomas Sjögren <[email protected]>
rebased |
Signed-off-by: Thomas Sjögren <[email protected]>
Failing tox test: #149 |
Hi @konstruktoid, it looks that the mentioned PR that is already merged is not enough to pass the ruff checks. |
Will take a look |
Signed-off-by: Thomas Sjögren <[email protected]>
All checks have passed. |
Basic ruff formatting for journald source plugin Signed-off-by: Thomas Sjögren <[email protected]> --------- Signed-off-by: Thomas Sjögren <[email protected]> Co-authored-by: Tom Tuffin <[email protected]> Co-authored-by: Alex <[email protected]>
Ref #135