Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy and ensure we pass with strict mode #258

Closed
12 of 19 tasks
ssbarnea opened this issue Aug 15, 2024 · 0 comments · Fixed by #290
Closed
12 of 19 tasks

Enable mypy and ensure we pass with strict mode #258

ssbarnea opened this issue Aug 15, 2024 · 0 comments · Fixed by #290
Assignees
Labels
bug Something isn't working

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Aug 15, 2024

A progressive approach would be highly desirable here, as we also have to merge a lot of new code into the repository.

  • enable mypy via pre-commit with minimal mode
  • activate "arg-type"
  • index
  • var-annotated
  • union-attr
  • return-value
  • attr-defined
  • override
  • assignment
  • misc
  • return
  • disallow_untyped_calls = true
  • disallow_untyped_defs = true
  • disallow_any_generics = true
  • disallow_any_unimported = True
  • warn_redundant_casts = True
  • warn_return_any = True
  • warn_unused_configs = True
  • strict = true (keep this last)
@ssbarnea ssbarnea added the bug Something isn't working label Aug 15, 2024
@ssbarnea ssbarnea self-assigned this Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
@ssbarnea ssbarnea pinned this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
* Address arg-type, return and return-value type errors

Related: #258
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 15, 2024
ssbarnea added a commit that referenced this issue Aug 16, 2024
ssbarnea added a commit that referenced this issue Aug 16, 2024
ssbarnea added a commit that referenced this issue Aug 16, 2024
ssbarnea added a commit that referenced this issue Aug 16, 2024
@Akasurde Akasurde unpinned this issue Aug 20, 2024
@Akasurde Akasurde pinned this issue Aug 20, 2024
ssbarnea added a commit that referenced this issue Aug 28, 2024
ssbarnea added a commit that referenced this issue Aug 28, 2024
ssbarnea added a commit that referenced this issue Aug 28, 2024
ssbarnea added a commit that referenced this issue Aug 28, 2024
ssbarnea added a commit that referenced this issue Aug 28, 2024
ssbarnea added a commit that referenced this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant