Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable Redis #210

Closed

Conversation

rooftopcellist
Copy link
Member

This PR makes it possible to disable redis by setting eda.spec.redis.disabled: true. This might be desired if configuring an external redis instance via the env settings.

  extra_settings:
    - setting: EDA_MQ_USER
      value: '{{ eda_redis_username | b64decode }}'
    - setting: EDA_MQ_USER_PASSWORD
      value: '{{ eda_redis_password | b64decode }}'
    - setting: EDA_MQ_HOST
      value: '{{ eda_redis_host | b64decode }}'
    - setting: EDA_MQ_PORT
      value: '{{ eda_redis_port | b64decode }}'

Alternative Idea:

However, I think it might be better all around to make it so that the redis configuration is done via a k8s secret, and the presence of that k8s secret being specified on the EDA spec would indicate that an external Redis instance is being used configured and that the default redis pod/deployment/service should not be created.

@rcarrillocruz What do you think about that idea? If that's better, I can close this and implement it tomorrow.

@rooftopcellist
Copy link
Member Author

Discussed oob. I'll close this PR and open one to make it configurable via a redis secret that can be swapped out for External Redis Configuration secret. And then we'll key off of it's presence to determine whether or not to create the default redis deployment/svc/pod etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant