Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to disable redis by setting
eda.spec.redis.disabled: true
. This might be desired if configuring an external redis instance via the env settings.Alternative Idea:
However, I think it might be better all around to make it so that the redis configuration is done via a k8s secret, and the presence of that k8s secret being specified on the EDA spec would indicate that an external Redis instance is being used configured and that the default redis pod/deployment/service should not be created.
@rcarrillocruz What do you think about that idea? If that's better, I can close this and implement it tomorrow.