Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker engine for container build make targets in release GHA #189

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

rooftopcellist
Copy link
Member

- engine defaults to podman, but podman does not support all docker
  buildx features at the moment
- for now, we can solve this by using docker everywhere in this workflow
- fix galaxy-operator image refs in CSV

I have re-pushed 1.0.0 and 1.0.1 with these changes and confirmed that the full image is now present in the resulting CSV in the bundles.

Before:

$ opm alpha bundle unpack quay.io/ansible/eda-server-operator-bundle:1.0.1
$ cat manifests/eda-server-operator.clusterserviceversion.yaml | grep image: | grep eda-server-operator:1.0.1
                image: eda-server-operator:1.0.1

After:

$ opm alpha bundle unpack quay.io/ansible/eda-server-operator-bundle:1.0.1
$ cat manifests/eda-server-operator.clusterserviceversion.yaml | grep image: | grep eda-server-operator:1.0.1
                image: quay.io/ansible/eda-server-operator:1.0.1

    - engine defaults to podman, but podman does not support all docker
      buildx features at the moment
    - for now, we can solve this by using docker everywhere in this workflow
    - fix galaxy-operator image refs in CSV
@rooftopcellist rooftopcellist merged commit d83c242 into main Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant