update jinja2 #244
Closed
update jinja2 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doh! if I just did nox it would have updated thsi for me.. closing this pr... be back soon. |
| @@ -1,5 +1,7 @@ | |||
| #-c constraints.in # <-- contains known limitations | |||
|
|
|||
| staticjinja >= 5.0.0 # generates html from templates | |||
| jinja2 >= 3.1.4 # need more recent version than staticjinja, | |||
There was a problem hiding this comment.
Actually staticjinja does not need this specific version. 3.1.3 was just picked by dependency resolution as the latest jinja2 release that was available when requirements/requirements.txt was built.
So removing this line again and rebuilding requirements/requirements.txt will also give you the fixed version.
(Keeping this one here is also fine, but I would remove the reference to staticjinja, since that package has nothing to do with the jinja2 version chosen. Better reference the CVE here.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on CVE-2024-34064.
Once staticjinja produces a release with this updated jinja2 version or later, we can remove this extra line.