Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pip compile req file path relative to project #239

Merged
merged 3 commits into from
May 23, 2024

Conversation

oraNod
Copy link
Collaborator

@oraNod oraNod commented Apr 15, 2024

This change results in the paths of the output and input files relative to the project directory when pip-compiling requirements.

@samccann
Copy link
Collaborator

Ran this locally and it all worked. I can't comment on the code itself but this also fixed the problem I have in https://github.com/ansible/docsite/pull/245/files#r1610634115

@samccann
Copy link
Collaborator

@felixfontein @gotmax23 can you give this one a quick review pls? I tried it locally and it works but I can't say much about the actual diffs :-)

@gotmax23
Copy link
Contributor

diff --git a/noxfile.py b/noxfile.py
index dac7a7a..bbe56d8 100644
--- a/noxfile.py
+++ b/noxfile.py
@@ -2,7 +2,7 @@ from pathlib import Path
 
 import nox
 
-requirements_directory = Path("requirements").resolve()
+requirements_directory = Path("requirements")
 
 requirements_files = [
     requirements_input_file_path.stem

would have the same effect with less code.

oraNod and others added 3 commits May 23, 2024 17:28
This change results in the paths of the output and input files relative
to the project directory when pip-compiling requirements.
Co-authored-by: Maxwell G <[email protected]>
@samccann samccann merged commit ca6805f into ansible:main May 23, 2024
2 checks passed
@samccann
Copy link
Collaborator

Thanks @felixfontein and @gotmax23 for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants