Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the jinja-docsite source files to the main branch #182

Merged
merged 13 commits into from
Aug 23, 2023

Conversation

oraNod
Copy link
Collaborator

@oraNod oraNod commented Aug 10, 2023

This PR replaces the static contents of the main branch with the source from https://github.com/ansible/jinja-docsite

This PR also includes a workflow for updating the contents of the prod branch that gets deployed to the web server via Jenkins. Also adds a Read The Docs configuration to build previews on RTD.

PR preview/demo: https://stage-docsite--182.org.readthedocs.build/en/182/.

@oraNod oraNod requested a review from samccann August 10, 2023 17:13
@samccann
Copy link
Collaborator

Is this required to support the docs releases coming next week? I'm asking for a freeze of everything docs build releated by EOB today so we know all is stable. Maybe this (and its matching jenkins build) waits to merge after the releases? Probably a week from now.

@oraNod
Copy link
Collaborator Author

oraNod commented Aug 10, 2023

@samccann It's fine to wait a week.

.github/workflows/build-docsite.yaml Outdated Show resolved Hide resolved
.github/workflows/build-docsite.yaml Outdated Show resolved Hide resolved
.github/workflows/build-docsite.yaml Outdated Show resolved Hide resolved
.github/workflows/build-docsite.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
build.py Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
constraints.in Outdated Show resolved Hide resolved
requirements.in Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go in general, regardless if you'll want to apply that last suggested change.

@webknjaz
Copy link
Member

@oraNod I got the maintainer to get rid of the dependency in staticjinja: staticjinja/staticjinja#186 (comment) — could you update it and re-add the strict warnings mode env var?

oraNod and others added 9 commits August 17, 2023 12:51
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>

mkdir rtd html

avoid unnecessary subdir
Co-authored-by: Sviatoslav Sydorenko <[email protected]>

rm unused action

docsite ci

Co-authored-by: Sviatoslav Sydorenko <[email protected]>

Update .github/workflows/ci.yaml

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@oraNod
Copy link
Collaborator Author

oraNod commented Aug 17, 2023

I've rebased and squashed a bunch of commits to make it easier on additional reviewers.

Copy link

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the PR build LGTM!

Thanks for all the work here!

@samccann samccann merged commit a6f7e4f into ansible:main Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants