-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the jinja-docsite source files to the main branch #182
Conversation
Is this required to support the docs releases coming next week? I'm asking for a freeze of everything docs build releated by EOB today so we know all is stable. Maybe this (and its matching jenkins build) waits to merge after the releases? Probably a week from now. |
@samccann It's fine to wait a week. |
20c5cea
to
3971d86
Compare
7824a45
to
530576c
Compare
4c6f402
to
7bdf101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go in general, regardless if you'll want to apply that last suggested change.
@oraNod I got the maintainer to get rid of the dependency in staticjinja: staticjinja/staticjinja#186 (comment) — could you update it and re-add the strict warnings mode env var? |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]> mkdir rtd html avoid unnecessary subdir
Co-authored-by: Sviatoslav Sydorenko <[email protected]> rm unused action docsite ci Co-authored-by: Sviatoslav Sydorenko <[email protected]> Update .github/workflows/ci.yaml Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
e512839
to
54c1d56
Compare
I've rebased and squashed a bunch of commits to make it easier on additional reviewers. |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
20d14ce
to
ca2aaa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the PR build LGTM!
Thanks for all the work here!
This PR replaces the static contents of the main branch with the source from https://github.com/ansible/jinja-docsite
This PR also includes a workflow for updating the contents of the
prod
branch that gets deployed to the web server via Jenkins. Also adds a Read The Docs configuration to build previews on RTD.PR preview/demo: https://stage-docsite--182.org.readthedocs.build/en/182/.