Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relaunch against failed hosts #9225

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Feb 3, 2021

Add relaunch against failed hosts

See: #8670

image

Job Output

image

Job Details
image

@unlikelyzero
Copy link

We currently have some stubs in this area but we know that they're not complete.

  1. Need to make sure it's responsive
  2. Should only see if user has permissions to launch (i.e. auditor should not see button)
  3. Displayed on Jobs Detail Page
  4. Displayed on Job result Output Page
  5. Displayed on Jobs List Page
  6. Test that it can launch on all
  7. Test that it can launch only on Failed Hosts

Need to add visual test for component

Not add regression tests but check that:

  1. Works with expanded and collapsed view
  2. Should re-use original POL parameters
  3. Check to see if it appears on Slice Job Templates and Workflow Templates

@one-t
Copy link
Contributor

one-t commented Feb 10, 2021

Hey, @nixocio - this is currently not displaying the relaunch on failed hosts option on the details page and the output page. It's only available in the jobs list view. Should that be covered by this PR?

@nixocio
Copy link
Contributor Author

nixocio commented Feb 12, 2021

Hey @one-t, I will add those changes on this PR as well. Thanks.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero
Copy link

@nixocio is this ready for test again?

@nixocio
Copy link
Contributor Author

nixocio commented Feb 12, 2021

@nixocio is this ready for test again?

yes, I already talked with @one-t.

Add relaunch against failed hosts

See: ansible#8670
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@one-t one-t added the mergeit label Feb 15, 2021
@one-t
Copy link
Contributor

one-t commented Feb 16, 2021

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 56868db into ansible:devel Feb 16, 2021
@kannurkars
Copy link

how to get this feature/bugfix in 17.1,0 (i cannot upgrade to 18 or 19).

@wenottingham
Copy link
Contributor

You would have to perform a backport/build yourself - we do not backport bugfixes to older releases upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui type:feature prioritized on a feature board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants